btw to answer the question on why a full conversion to mapid if zonetext was working. zonetext is only as good as locals, and at any given time we always have 3 that are on the ball and rest that come in short.in fact right now BC mods are only localized in 3 languages, which means that there is ZERO support for even loading the mods at all when zoning into an instance. i look forward to 4.0.3 when i can swap that over to map method too.

granted, ICC was localized in most/all languages by time i converted it. but it was more of a proving ground for the concept...and asside from this small misshap which i hope is fixed now. proved quite efficent.

to continue to provide the best support for day 1 mods/alphas in future, it'll continue to be the superior method. we want mods to work as much as possible out of the package, without waiting for days or weeks or even months at a time for someone to localize it in another language. so as much spellid or map based loading as possible or generic function usage to make sure mods work as much as posisble with as little local as possible. about the only thing we might have to localize is stuff that usually doesn't show in combat log, phase trigger yells etc. that's unavoidable. :\

i tried the newest alpha version 4.63-r4590-alpha
it works perfectly in ICC now, all the timers and everything on all the bosses. However it severely lags now. Several raid members tried it but had to turn it off after marrowgar, i left it on till sinda just to see how it would pan out, when you start casting your framerate drops. In areas with large amounts of mobs it goes down to 1-2FPS (like the mobs before sindragosa you can barely move your mouse anymore). Without DBM it stays above 90+ FPS. This was tested with no other non-blizzard addons to make sure there wasn't anything conflicting with DBM. The raid members who ended up disabling the alpha after marrowgar retained their normal framerate.

that's very strange. since this change cetainly shoudln't have altered framerates. you sure they didn't just get the grahics lag bug that goes away if you tab out and back in? (basically toggle full screen)

nope, most of them switched back to the 4564 version which unfortunately doesnt work for any of them.. but they stopped lagging after that.. i relogged a couple times and closed the game once and rebooted.. but it did nothing. the game is fine with anything else.. herbing killing single mobs by yourself... but in group situations with many mobs.. even in a 5 player dungeon there is little freezes which do not occur in the old dbm's. i dont run anything else when raiding.. i turn everything off except DBM.

i cannot reproduce that problem what so ever.

but i have noticed that now dbm is doing setcurrent map every 5 seconds, non stop. which is puzzling since i'm just standing around in dalaran.

i just think the sync/pull handling needs to be redone all together, honestsly it's dumb to check zone for those things. the other checks are enough. (ie checking raid targets for valid creatureid on combat regen disabled event, or pull string.

raidwatch2 uses mapid based loading but that's all it's use for, loading, not pulls, not syncs, not on event calls, just loading..

ok, have them try alpha 4592 and see if it still behaves same, it's now only gonna do SetMapToCurrentZone() on pull or zone change that's it. not for every single sync like it was doing. For most part this should be 99.99999% fine. far as oscar was saying his mod was changing map id on teleporters, not in middle of combat...unless a player specificly decides inmiddle of a boss fight they were gonna open map and start browsing other areas, it's safe to assume if you set id on combat start it should be right the entire fight. i can't fathom any other mod changing it in middle of combat either.

awesome ill give this a try tonight in ICC. thanks for the fixes

i tried to do random dungeons on 3 characters all characters froze when loading the dungeon, didnt even show bar movement just straight out frozen .

I've also noticed severe framerate problems since updating to the latest DBM alpha, although until I saw Inflikted's post I didn't connect that the new version of DBM may be the culprit.

It's entirely possible that some unrelated DBM change between 4564 and 4592 is responsible for nuking our frame rates, but either way I'm rolling back to 4564 and applying my patch there since I don't trust the current alpha.

Incidentally, I think that non-map-related addons have no business permanently changing the map to serve their own purposes. The map is a resource which is part of the default UI and its settings belong to the USER not to whatever addon thinks it is most important.

After all, you think it's "wrong" for another addon (say a Wintergrasp status addon) to permanently change the map to the wintergrasp zone when it updates every 10 seconds, so why is it any more justified for the DBM addon to permanently change the map to an ICC zone every few seconds? Neither is ok - the map setting belongs to the USER and if some addon needs to temporarily change it to perform a query then it should also change it back to avoid disturbing the user experience.

the latest alpha is not changing the map anymore though unless it apsolutely has to. only when you enter combat or change zones. change zones the game changes map to current map anyways so tha tline of code is really only for /reloadui or disconnects (if you don't force set change map on zone change from a DC, when you load back into ICC your map isn't set to ICC, you mods dont load). but map should never be changed back when pulling a boss though. if you change it back you cannot use arrows or map based range checks at all. more users would complain about that functionality not working than anything. those require the current map plain and simple. besides, i still don't see ANY reason at all why the user would honestly need their map while busy fighting a boss to be somewhere else. i can understand when running around dalaran or even inside ICC< and that i fixed already, dbm will not touch the map at all for that. but having your map looking at zangermarsh while fighting heroic LK honestly screw the one user that would rathor have his map set back to zangermarsh on a boss fight. he'd just end up here complaining why he can't see shadow trap arrows.

btw speaking of maps has anyone botherd to check if in 4.0.1 it's possible to put defile arrows back? or does the map still go invisible during phase 2 when outer ledge is collapsed?

i still cannot reproduce the fps loss at all nor can i think of any reason there are major fps loss on 4592, 4590 yeah that probabl was causing it when i saw that it was literally spamming change map every time there was a chat, boss, or sync event. but you still had problems with 4592?

Inflikted, is that all you tested, going into an instance? the freeze on loading screen happens regardless of dbm, just more often cause of dbm and that i could not figure out why, i even tried things as drastic as teling dbm to do apsolutely nothingon zone change for 20 seconds and that didn't help. but if you look through all the bug/tech forums you'll find a ton of users are getting that freeze on loading screen dbm or not...i'm more interested if you still get the combat lag/fps problems you were talking about still. i think that loading screen crap is a 4.0.1 bug that for whatever reason, dbm just makes worse, probably cause it hooks into PLAYER_CHANGED_ZONE. that api is probably buggy right now for some reason.

Quoted from ""Omega""

the latest alpha is not changing the map anymore though unless it apsolutely has to. only when you enter combat or change zones.

So you think it's ok to change the map every time the raid makes a trash pull while the raid leader hangs back using his map to see who still needs summons? At the very least you should make sure it is indeed a boss pull that activates a mod and set it back otherwise.

Quoted from ""Omega""

honestly screw the one user that would rathor have his map set back

... and this is the attitude that makes people drop your mod and switch to one where the developers do care about not creating an aggravating the user experience. (hello Deus Vox Encounters..)

It also goes without saying that anyone is going to drop a boss mod that nukes their frame rates, so fixing that should be paramount. Nobody cares about your fancy run-away arrows and other bells-n-whistles if it makes the play screen look like stop-motion animation.

well there is no real better way to do it with combat regen to say "but ignore trash".

and people care more about functionality than anything. heck it took months for like 2 people out of 10s of thousands to even notice dbm broke if it was on a different map. that tells you how small of a minority those poeple are. any feature is always about caitoring to majority. that said I have noted the issues with current core depending so much on it as you can see in svn log, i do plan on talking to tandanu about not checking areaid for EVERY single event dbm does, that's just bad design in general. it should not be required for syncs or events or chat yells like it is now...however as i said above it will always be required for /range and arrow functions. that is just a limitation of those features. and when it comes to that, then setting current map on a boss pull to make sure everything works is more important than one user who's upset he can't look at zones he's not in on trash. that's not bad attitude that's prioritizing the many over a minority. i'm not against adding a pref for it in core in fact that basically says "leave my map alone (your boss mods will be less functional)". but that would be off by default.

also no where did i say "screw your fps".

I asked for more information, as i cannot reproduce this problem on 4592, so either you didn't test latest alpha. or there is another variable than just maps which would be wierd since the only chances since release was onyxia sounds being converted to ogg, adding a b unch of cata raids, and the map change, that's it. wihch is why map change was first thing tested. but freezing on the instance portal is NOT the same issue as fps you guys complained about. and the map should only be chanced ONCE< on pull, so i can't see remotely how that'd be lagging you in combat anymore like 4590 probably was. personally if anything i find you having more of an attidue, the other guy is cool and is being helpful. you're so strong about your opinion that we should purposely break mod functoinality to caitor to a really tiny minority. just cuase YOU don't care about the arrows or range finders. I know a LOT of poeple who heavily rely on range 8, or range 12 in ICC, tell those users that those features might not work cause they forgot to set their map back to current zone on the pull and there will be more annoyed users in that scenario then now. half the encounters in ICC are about maximizing your space.

but considering DBM has been ussed for over a year with maybe 3 bug reports about range finder not working on those fights. it's no surprise the other mods haven't needed to force set map on the pull for those encounters, like DBM, it was a bug that could easily get overlooked. it just got noticed in dbm first cause we (and admitidly stupidly) also rely on map for pull, osmething that should be fixed IMO. IF this does get fixed, THEN i can move the set map from combat regen to boss engage function and it'll no longer do it on trash either. i bet if i talked to raidwatch guys or osmething and said that map based range finders might not work if user is on wrong map they might also set map on boss pulls too to fix that bug. Theirs of course would be better cause they could avoid doing it on trash (again it goes back to dbm needing work on pull mechanics, combat regen is not a desirable place to put it, but the only place right now, but that's what an ALPHA is, a work in progress, it's not like i tagged a new release). I'll add an option to core later to override this behavior. but as i said that's low priority. fps IS the high priority which is why again i asked that guy if he actually tested raid combat and not just instance portal. cause guess what, 4564 already set map on instance portal, there should be apsolutely no difference AT ALL between 4564 and latest alpha when zoning in. none at all, i reverted the code exactly to as it was in last release in 4564 with the exception of adding the set map to pulls. so if you're hanging on instance portal now and not with public release, that's coincidence cause they are identicle there. you can check svn log yourself and see that 4564 and 4592 really are identicl code wise with exception of map check on pull., and a bunch of new cata mods which for most part you should turn off since that content isn't in game yet.

Quoted from ""Omega""

it took months for like 2 people out of 10s of thousands to even notice dbm broke if it was on a different map. that tells you how small of a minority those poeple are.

No actually, there's just the 3-4 of us talking in this thread, but I've talked with dozens of people on my server who've all noticed that since the patch DBM is no longer reliable and frequently just randomly fails to notice boss pulls. Many of the people in my guild have already dropped DBM in favor of other boss mods they perceive to be more reliable. The 3-4 of us are just the ones who've noticed that the map setting is responsible for the intermittent failures. I'm personally a fan of DBM (I even do occasional DBM development) so I would like to see this get fixed as quickly and effectively as possible so people can go back to relying on DBM.

really, cause if they reported it, instead of switching mods they probably woulda gotten it fixed sooner. i saw maybe 2 curse comments and this thread on issue, and most of the time it wasn't enough information to really figure anything out til i got people willing to do some debug for me.

who you really should be complaining too is tomtom arrow, why on earth would you set map to -1 all the time?

Quoted from ""Omega""

who you really should be complaining too is tomtom arrow, why on earth would you set map to -1 all the time?

I've reported the issue to them as well - although in their case they're actually trying to be responsible and set the map back to the user's settings, it just that code is buggy and incorrectly sets it to -1 in icc. -1 is a valid setting by the way - it corresponds to zooming all the way out to the continent level.

trust me when i say this, if i add code in to change map back after a check, what will happen is this. you open map, set it to dalaran to look at your stragglers, you go to pull a boss, it checks curent map, pull detection works, but then sets it back to dalaran, then you'll be on blood queen with a broken range 8. or saurfang with broken range 12, etc.

there is no way around these functions requiring the right map. so I WILL be forcing to correct map when you engage a boss, that said however.
i'm talking with nitram right now about a proposed fix for trash though. we will probably cache the map on zone login, and not set it on combat regen, cause it'll be cached. then, on boss pulls (engage an actual boss, not combat regen) set it to current map so all functions work for that boss fight, on combat end restore map.

what if somebody always has the shift+M zone map on?

Quoted from ""Omega""

there is no way around these functions requiring the right map. so I WILL be forcing to correct map when you engage a boss, that said however.
i'm talking with nitram right now about a proposed fix for trash though. we will probably cache the map on zone login, and not set it on combat regen, cause it'll be cached. then, on boss pulls (engage an actual boss, not combat regen) set it to current map so all functions work for that boss fight, on combat end restore map.

That sounds like a reasonable middle-ground.

Quoted from ""thafuture""

what if somebody always has the shift+M zone map on?

that shouldn't matter.

i'm almost done with the new code. i think it'll work but i'll need some testing


i still hope you guys can do some fps testing with it soon once i commit it, it should use even less cpu than last lelease did since it's no longer even checking area id every sync or event either just using a cached value.