Dear visitor, welcome to Gaming Insight Forum. If this is your first visit here, please read the Help. It explains in detail how this page works. To use all features of this page, you should consider registering. Please use the registration form, to register here or read more information about the registration process. If you are already registered, please login here.

Tennberg

Intermediate

  • "Tennberg" started this thread

Posts: 275

Occupation: Grammar policeman

  • Send private message

1

Tuesday, October 27th 2009, 6:17am

Questions before new release goes out

1. I renamed the frame for Anub'arak in ToC and Anub'arak in Azjol-Nerub to both be spelled "Anub'arak". However, this seemed to cause an error when both mods were loaded while I was going through looking for changes to make. Any way to fix it other than having one of the frames called "Anubarak"?

2. Eck the Ferocious in Gundrak has an "Announces" frame in his mod, but it's blank. How do I remove it?

3. Ley-Guardian Eregos in Oculus has an option showing as "WarningEnraged". It's been forever since I've run 5-mans. What is this supposed to say?

4. Ingvar the Plunderer has an option showing as "SpecialWarningSpellock". I'm assuming I just need to put down "SpecialWarningSpellock = "Show special warning for spell lock".

5. Svala Sorrowgrave in UP has an option showing as "Ritual of the Sword". What should this say? "Show warning for..."? Something else?

6. In DBM-Core, there's a line that says"

DBM_CORE_BOSS_DOWN_LONG = "%s down after %s! Your last kill took %s and your fastest kill %s."

Should it instead say:

DBM_CORE_BOSS_DOWN_LONG = "%s down after %s! Your last kill took %s and your fastest kill took %s."

I don't have any screenshots that have this text in it, nor am I raiding tonight to find out what it puts into chat. Anyone know?

I'll get these updates committed once I get some responses.

2

Tuesday, October 27th 2009, 11:00am

1. no .. we never planned DBM to have bossmods twice .. so the BossName have to be Unique
6. this message appers each time you kill a Boss in normal time.

3

Tuesday, October 27th 2009, 1:10pm

1. Boss names need to be unique because we didn't expect the same boss to show up twice :/ It would be possible to use something like "Anub'arak (5)" in the party mod.

2. This requires a code change in the mod, I'll do this later today.

4. Yes

6. "<Boss name> down after x minutes and y seconds! Your last kill took x min and y seconds and your fastest kill x minutes and y seconds."

Tennberg

Intermediate

  • "Tennberg" started this thread

Posts: 275

Occupation: Grammar policeman

  • Send private message

4

Tuesday, October 27th 2009, 4:43pm

I've fixed #1 and #4 so far, but US realms are down, so I will verify them once they're up.

5

Tuesday, October 27th 2009, 7:56pm

3. This warn is shown every time the boss gains Enraged Assault

5. This warning is shown every time the boss casts Ritual of the Sword. It does not show the target of the spell.

6

Tuesday, October 27th 2009, 8:06pm

Quoted from ""Tandanu""

3. This warn is shown every time the boss gains Enraged Assault

5. This warning is shown every time the boss casts Ritual of the Sword. It does not show the target of the spell.


3. Instead of "WarningEnraged" it should show something like: Show warning for "Enraged Assault"

5. The person who gets targeted by it gets 3 or 4 of the same debuff doesn't he? Couldn't DBM scan for that debuff and find the target that way? Also instead of showing just "Ritual of the Sword" it should be: Show warning for "Ritual of the Sword" :)
<!-- m --><a class="postlink" href="http://us.battle.net/wow/en/character/kilrogg/gilora/advanced">http://us.battle.net/wow/en/character/k ... a/advanced</a><!-- m -->

Tennberg

Intermediate

  • "Tennberg" started this thread

Posts: 275

Occupation: Grammar policeman

  • Send private message

7

Tuesday, October 27th 2009, 8:31pm

Fixed #3 after a couple attempts.

#5 doesn't make any sense why it's not showing up as "Show warning for..." since the code format looks correct. Could someone take a loot at Svala in the party mod and see why Ritual of the Sword is showing up as "Ritual of the Sword" and not "Show warning for "Ritual of the Sword""?

8

Tuesday, October 27th 2009, 9:02pm

The problem seems to be that the mod uses the spell's name as identifier for the announce (wtf!)

Use the following code in the SetOptionLocalization part of the mod to translate it:

[GetSpellInfo(48276)] = "Show warning for Ritual of the Sword",

9

Tuesday, October 27th 2009, 10:56pm

why would you change party mods to dungeons? granted most sub catagories are dungeon, but world events is iffy as "world events" cannot be declared as a dungon in that of itself since it's spread in multiple locations. It fits more in the description of party mod. As for renaming dungeons also rquires you to rename the mod folder, rename the toc, change a line in just about every local and every dungeon mod to match the rename dtoc ie local mod = DBM:NewMod("Anubarak", "DBM-Party-WotLK", 2), then warn users upon upgrading to delete their old dbm-partymods folder if the new folder is dbm-dungeons. it's more of a mess than it's worth imo.

Tennberg

Intermediate

  • "Tennberg" started this thread

Posts: 275

Occupation: Grammar policeman

  • Send private message

10

Tuesday, October 27th 2009, 11:10pm

Quoted from ""Omega""

why would you change party mods to dungeons? granted most sub catagories are dungeon, but world events is iffy as "world events" cannot be declared as a dungon in that of itself since it's spread in multiple locations. It fits more in the description of party mod. As for renaming dungeons also rquires you to rename the mod folder, rename the toc, change a line in just about every local and every dungeon mod to match the rename dtoc ie local mod = DBM:NewMod("Anubarak", "DBM-Party-WotLK", 2), then warn users upon upgrading to delete their old dbm-partymods folder if the new folder is dbm-dungeons. it's more of a mess than it's worth imo.


All I did was change the dropdown menu display text in the GUI from "Party Boss Mods" to "Dungeons", so that it looks like this:

<!-- m --><a class="postlink" href="http://img259.imageshack.us/i/wowscrnshot102709180441.jpg/">http://img259.imageshack.us/i/wowscrnsh ... 80441.jpg/</a><!-- m -->

Also, both the "World Events" of Coren Direbrew and Horseman take place in dungeons (BRD and SM, respectively).

I haven't noticed any errors in DBM by making this display change. If this change should not have been made and affects more than just the text display, I can revert it to the original of "Party Boss Mods".

11

Tuesday, October 27th 2009, 11:19pm

no errors, but cosmeticly incorrect, calling it party in one place then dungeons in another, if you change one you should change all so that appearance is consistent.

But reason dungeons doesn't make sense as a catagory is cause then one would expect that the subtagories are "dungeons"
but "world events" is not a dungeon. every sub catagory in that mod is a party mod, but not every sub catagory is a dungeon, if that makes sense? world events are in a dungeon, but world events is not a dungeon. ;) i'm trying to make sense but it doesn't sound like it heh.

Tennberg

Intermediate

  • "Tennberg" started this thread

Posts: 275

Occupation: Grammar policeman

  • Send private message

12

Tuesday, October 27th 2009, 11:47pm

Quoted from ""Omega""

no errors, but cosmeticly incorrect, calling it party in one place then dungeons in another, if you change one you should change all so that appearance is consistent.

But reason dungeons doesn't make sense as a catagory is cause then one would expect that the subtagories are "dungeons"
but "world events" is not a dungeon. every sub catagory in that mod is a party mod, but not every sub catagory is a dungeon, if that makes sense? world events are in a dungeon, but world events is not a dungeon. ;) i'm trying to make sense but it doesn't sound like it heh.


Well, you could always put Coren Direbrew in the BRD mod and Horseman in the SM mod ;-)

Can we agree on calling it "Party"? The fact that it was called "Party Boss Mods" was bothering me, as when it was loaded, it would say "Loaded "Party Boss Mods" boss mods."..../facepalm

13

Tuesday, October 27th 2009, 11:51pm

ah, i guess that does make sense. Party sounds good.